Page 1 of 1

Just sent final Beta Verification release for EU testing

Posted: Sun Jul 17, 2016 11:07 pm
by bringoutyourdead
This version works fine on PTR
(which means I couldn't test Demon Hunters and 101->110 levels)

I don't expect any issues with this as previous testing on Beta showed no issues with those areas.

New French translations included.. (had to make minor tweaks to handle multi-line tooltips... replacing CR-LF with Lua \n coding.)

Posted: Mon Jul 18, 2016 10:05 pm
by bringoutyourdead
and oops!
I had forgotten to add the new class to CurseForge translations... fixed

and fixed for current localizations EN,DE,FR,ES,IT
and RU... though I do not know if what Blizzard had on web is also what is in game.

Apparently Blizzard may have a problem.. or just an Beta oddity..
I looks like
/who c-Demon Hunter
and
/who c-Hunter
may both trigger the same response from the server

We will need to see if that is true on live
(current impact is duplicate effort when scanning by those classes)

It may require another CensusPlus minor update before the expansion pack goes live.

Posted: Tue Jul 19, 2016 12:23 am
by FuxieDK
It's 19/7-16, 8:20 CET, here in Europe and game is still not patched..

Maybe only US gets it today (EU normally gets patches on wednesday)..

I leave for Sardinia in a few hours, so I cannot test anything until tuesday or wednesday, next week..

EDIT: Could quotes help fix the Hunter/DH issue? /who c-"Demon Hunter" ?
Or maybe /who c-Demon (which will probably be a translation nightmare)...

Posted: Tue Jul 19, 2016 1:07 am
by FuxieDK
FuxieDK wrote:Maybe only US gets it today (EU normally gets patches on wednesday)..
Yup... I was right --> http://eu.battle.net/wow/en/blog/201764 ... 15-07-2016

Posted: Sun Aug 14, 2016 4:47 am
by FuxieDK
As I see it (I see no /census c-Demon Hunter in the log), Demon Hunters are not censussed at all, simply because they are covered by Hunter census..

While this works in English, are we ABSOLUTELY sure it works for all other languages as well? Both current and potential future localizations?

How about something like this (pseudo code):

Code: Select all

if RACE = NELF or RACE = BELF then
   if HUNTER is not a subset of DEMONHUNTER then
      add DEMONHUNTER to queue
   endif
   add HUNTER to queue
endif
This way, we would get a specific DH entry in the queue, if it (in the current localization) doesn't contain the same translation as HUNTER.
If it does contain it (like in English), it will be covered by the HUNTER entry..
Race can ofc be changed, once Blizzard decides to add additional races for this class.

And it will work for all future languages..

Posted: Sun Aug 14, 2016 5:46 pm
by bringoutyourdead
For the languages the website can support, the answer is yes.. or I wouldn't have implemented the change.

Just for your information.. game localizations do not work as you think.. same trap I started to fall into until I remembered.

Posted: Mon Aug 15, 2016 12:29 am
by FuxieDK
OK...

Once Swahili gets added to the game, and the names are totally different, then that problem will have to be resolved ;)

Posted: Mon Aug 15, 2016 10:05 am
by bringoutyourdead
Nope.. that assumes the website will ever get changed to support more then just UTF-8

We already fail to handle a number of Blizzard (or partner company) supported languages, Chinese, Korean, Russian.

Posted: Mon Aug 15, 2016 12:34 pm
by FuxieDK
Swahili uses "normal" letters ;)

Posted: Mon Aug 15, 2016 3:54 pm
by bringoutyourdead
Odd the first time I tried to get translations for Demon Hunter and Hunter in Swahili.. Google returned no translation, as if Swahili had not term for hunter.

I can conceive of no language that fails to have a word/symbol for hunter..
Wikipedia was confusing to me.. as it shows a number of Swahali sounds needing character combinations to convert to writing.

But be that as it may... if and when Blizzard adds a Kiswahili language pack we are already covered.

hunter = wawindaji :roll: 8)

Posted: Mon Aug 15, 2016 9:49 pm
by FuxieDK
Well, Swahili was actually just a mock example ;)

The only two words I remember in Swahili, from when I was in Kenya and Tanzania, are "mbuzi" and "mbuni".. They are goat and ostrich..

Posted: Tue Aug 16, 2016 11:49 pm
by FuxieDK
Quick thought: Maybe LibWho author (since the actual /WHO is "outsourced") can work some magic?

Posted: Wed Aug 17, 2016 12:01 pm
by bringoutyourdead
They have the same problem as we do.. and so do you...
it is how blizzards server responds to the query.
and it only respond to specific queries.

you can (I have) manually do the who with CensusPlus not enabled... and you get the same results.

If Blizzard were to add a new language where ' Demon Hunter' is not treated as "somthing Hunter" then we will have to turn on both queries.. and yes I would put in code that said only for the specific language that is different then all of the rest we currently support.

but this is borrowing trouble, that may never happen.

Posted: Wed Aug 17, 2016 2:10 pm
by FuxieDK
I know that LibWho have the same problem ;)

But since that Lib is doung the actual WHO-command, I was think alone the lines of some routines that refined the results, so only classes that match the search string 100% would be returned to the calling add (in our case CensusPlus)..

Posted: Wed Aug 17, 2016 3:07 pm
by bringoutyourdead
You are missing the point.. with no CensusPlus enable there is no libwho.

plain no addons enabled at all sees the same results with manual /who commands.